linux-kernel - Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 21:55:46 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jani Nikula" <jani.nikula@...ux.intel.com>,
 "Arnd Bergmann" <arnd@...nel.org>, linux-kbuild@...r.kernel.org,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Harry Wentland" <harry.wentland@....com>,
 "Alex Deucher" <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 "Lucas De Marchi" <lucas.demarchi@...el.com>,
 "Oded Gabbay" <ogabbay@...nel.org>,
 "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
 "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>,
 "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>,
 "Andrew Jeffery" <andrew@...econstruct.com.au>,
 "Linus Walleij" <linus.walleij@...aro.org>, "Joel Stanley" <joel@....id.au>,
 "Alexei Starovoitov" <ast@...nel.org>,
 "Daniel Borkmann" <daniel@...earbox.net>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Nathan Chancellor" <nathan@...nel.org>
Cc: "Nicolas Schier" <nicolas@...sle.eu>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
 linux-mm@...ck.org, llvm@...ts.linux.dev
Subject: Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote:
> On Tue, 26 Mar 2024, Arnd Bergmann <arnd@...nel.org> wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> index 475e1e8c1d35..0786eb0da391 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -50,7 +50,7 @@
>>   * the macros available to do this only define GCC 8.
>>   */
>>  __diag_push();
>> -__diag_ignore(GCC, 8, "-Woverride-init",
>> +__diag_ignore_all("-Woverride-init",
>>  	      "logic to initialize all and then override some is OK");
>
> This is nice because it's more localized than the per-file
> disable. However, we tried to do this in i915, but this doesn't work for
> GCC versions < 8, and some defconfigs enabling -Werror forced us to
> revert. See commit 290d16104575 ("Revert "drm/i915: use localized
> __diag_ignore_all() instead of per file"").

It works now.

The original __diag_ignore_all() only did it for gcc-8 and above
because that was initially needed to suppress warnings that
got added in that version, but this was always a mistake.

689b097a06ba ("compiler-gcc: Suppress -Wmissing-prototypes
warning for all supported GCC") made it work correctly.

     Arnd