linux-kernel - Re: [PATCH] Documentation: PM: Update platform_pci_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326045303.qy4przp73jcoutvh@dhruva>
Date: Tue, 26 Mar 2024 10:23:03 +0530
From: Dhruva Gole <d-gole@...com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <len.brown@...el.com>,
        Pavel Machek <pavel@....cz>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] Documentation: PM: Update platform_pci_wakeup_init()
 reference

Hi,

On Mar 25, 2024 at 17:09:53 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> platform_pci_wakeup_init() was removed by d2e5f0c16ad6 ("ACPI / PCI: Rework
> the setup and cleanup of device wakeup") but was still mentioned in the
> documentation.
> 
> Update the doc to refer to pci_acpi_setup(), which does the equivalent
> work.
> 

Thanks! Documentation does go unnoticed sometimes.

> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
> 
> pci_acpi_setup() is a firmware-specific wart in this otherwise generic
> paragraph, so maybe there's some better way to express this?
> 
>  Documentation/power/pci.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/power/pci.rst b/Documentation/power/pci.rst
> index 12070320307e..e2c1fb8a569a 100644
> --- a/Documentation/power/pci.rst
> +++ b/Documentation/power/pci.rst
> @@ -333,7 +333,7 @@ struct pci_dev.
>  The PCI subsystem's first task related to device power management is to
>  prepare the device for power management and initialize the fields of struct
>  pci_dev used for this purpose.  This happens in two functions defined in
> -drivers/pci/pci.c, pci_pm_init() and platform_pci_wakeup_init().
> +drivers/pci/, pci_pm_init() and pci_acpi_setup().

Reviewed-by: Dhruva Gole <d-gole@...com>


-- 
Best regards,
Dhruva