[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874jctwjhh.wl-tiwai@suse.de>
Date: Tue, 26 Mar 2024 08:16:42 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc: Gergo Koteles <soyer@....hu>,
Shenghao Ding <shenghao-ding@...com>,
Kevin Lu <kevin-lu@...com>,
Baojun Xu <baojun.xu@...com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
alsa-devel@...a-project.org,
linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols
On Mon, 25 Mar 2024 23:01:18 +0100,
Pierre-Louis Bossart wrote:
>
>
>
>
> > +++ b/sound/pci/hda/tas2781_hda_i2c.c
> > @@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,
> >
> > ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;
> >
> > + dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
>
> Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
> add the information with the dyndbg parameter, e.g.
>
> options snd_intel_dspcfg dyndbg=+pmf
Since this doesn't always show up, I don't mind to have the function
name shown explicitly there. OTOH, what bothers me is that all those
messages have a short format "__func__: %d" while the values are
utterly different, depending on the function. That can be confusing.
IMO, it'd be more user-friendly to indicate what values are presented,
too.
thanks,
Takashi
Powered by blists - more mailing lists