linux-kernel - Re: [PATCH v2 3/3] s390: supplement for ptdesc conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326074656.6078-C-hca@linux.ibm.com>
Date: Tue, 26 Mar 2024 08:46:56 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: akpm@...ux-foundation.org, vishal.moola@...il.com, hughd@...gle.com,
        david@...hat.com, rppt@...nel.org, willy@...radead.org,
        muchun.song@...ux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, Alexander Gordeev <agordeev@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>
Subject: Re: [PATCH v2 3/3] s390: supplement for ptdesc conversion

On Tue, Mar 05, 2024 at 03:21:54PM +0800, Qi Zheng wrote:
> After commit 6326c26c1514 ("s390: convert various pgalloc functions to use
> ptdescs"), there are still some positions that use page->{lru, index}
> instead of ptdesc->{pt_list, pt_index}. In order to make the use of
> ptdesc->{pt_list, pt_index} clearer, it would be better to convert them
> as well.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Janosch Frank <frankja@...ux.ibm.com>
> Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: kvm@...r.kernel.org
> Cc: linux-s390@...r.kernel.org
> ---
> v1 -> v2: fix build failure (cross compilation successful)
> 
>  arch/s390/include/asm/pgalloc.h |  4 ++--
>  arch/s390/mm/gmap.c             | 38 +++++++++++++++++----------------
>  arch/s390/mm/pgalloc.c          |  8 +++----
>  3 files changed, 26 insertions(+), 24 deletions(-)

Same here: Christian, Janosch, or Claudio, please have a look and
provide an ACK if this is ok with you.