linux-kernel - Re: [PATCH] virt: vmgenid: drop redundant .owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461a8c3d-460b-4ca4-aa90-b70685958f6f@linaro.org>
Date: Tue, 26 Mar 2024 09:07:52 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Theodore Ts'o <tytso@....edu>, "Jason A. Donenfeld" <Jason@...c4.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt: vmgenid: drop redundant .owner

On 26/03/2024 08:53, Krzysztof Kozlowski wrote:
> Core already sets .owner in acpi_bus_register_driver().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/virt/vmgenid.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/virt/vmgenid.c b/drivers/virt/vmgenid.c
> index b67a28da4702..8f6880c3a87f 100644
> --- a/drivers/virt/vmgenid.c
> +++ b/drivers/virt/vmgenid.c
> @@ -88,7 +88,6 @@ static const struct acpi_device_id vmgenid_ids[] = {
>  static struct acpi_driver vmgenid_driver = {
>  	.name = "vmgenid",
>  	.ids = vmgenid_ids,
> -	.owner = THIS_MODULE,

This does not make sense and is not correct.  I need to fix
acpi_bus_register_driver first(). Please ignore.

Best regards,
Krzysztof