linux-kernel - Re: [PATCH 17/28] net: realtek: r8169: Use PCI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3376d9e8-7841-43b6-846a-45c75975fbb1@gmail.com>
Date: Mon, 25 Mar 2024 22:19:41 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Damien Le Moal <dlemoal@...nel.org>, linux-pci@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Manivannan Sadhasivami <manivannan.sadhasivam@...aro.org>,
 linux-scsi@...r.kernel.org, "Martin K . Petersen"
 <martin.petersen@...cle.com>, Jaroslav Kysela <perex@...ex.cz>,
 linux-sound@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org,
 linux-serial@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org, ntb@...ts.linux.dev,
 Lee Jones <lee@...nel.org>, David Airlie <airlied@...il.com>,
 amd-gfx@...ts.freedesktop.org, Jason Gunthorpe <jgg@...pe.ca>,
 linux-rdma@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/28] net: realtek: r8169: Use PCI_IRQ_INTX

On 25.03.2024 08:09, Damien Le Moal wrote:
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
> 
> Signed-off-by: Damien Le Moal <dlemoal@...nel.org>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 5c879a5c86d7..7288afcc8c94 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5076,7 +5076,7 @@ static int rtl_alloc_irq(struct rtl8169_private *tp)
>  		rtl_lock_config_regs(tp);
>  		fallthrough;
>  	case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_17:
> -		flags = PCI_IRQ_LEGACY;
> +		flags = PCI_IRQ_INTX;
>  		break;
>  	default:
>  		flags = PCI_IRQ_ALL_TYPES;

Acked-by: Heiner Kallweit <hkallweit1@...il.com>