linux-kernel - Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 08:48:29 +0000
From: Conor Dooley <conor.dooley@...rochip.com>
To: Allen Lin <allencl_lin@...mail.com>
CC: Conor Dooley <conor@...nel.org>, Rob Herring <robh@...nel.org>,
	<dmitry.torokhov@...il.com>, <krzysztof.kozlowski+dt@...aro.org>,
	<conor+dt@...nel.org>, <jikos@...nel.org>, <benjamin.tissoires@...hat.com>,
	<linux-input@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen

On Tue, Mar 26, 2024 at 01:46:56PM +0800, Allen Lin wrote:
> Conor Dooley <conor@...nel.org> 於 2024年3月23日 週六 上午2:34寫道：
> >
> > On Fri, Mar 22, 2024 at 01:30:09PM -0500, Rob Herring wrote:
> > > On Fri, Mar 22, 2024 at 05:54:08PM +0000, Conor Dooley wrote:
> > > > On Fri, Mar 22, 2024 at 04:56:03PM +0800, Allen_Lin wrote:
> > > > > Add the HX83102j touchscreen device tree bindings documents.
> > > > > HX83102j is a Himax TDDI touchscreen controller.
> > > > > It's power sequence should be bound with a lcm driver, thus it
> > > > > needs to be a panel follower. Others are the same as normal SPI
> > > > > touchscreen controller.
> > > > >
> > > > > Signed-off-by: Allen_Lin <allencl_lin@...mail.com>
> > > >
> > > > note to self/Krzysztof/Rob:
> > > > There was a previous attempt at this kind of device. This version looks
> > > > better but might be incomplete given there's a bunch more properties in
> > > > that patchset:
> > > > https://lore.kernel.org/all/20231017091900.801989-1-tylor_yang@himax.corp-partner.google.com/
> > >
> > > Those don't look like properties we want coming back.
> >
> > Oh, I don't want most of them coming back either. There are some
> > supplies in there though that I think we would like to come back, no?
> > Maybe this particular device doesn't have any supplies, but that doesn't
> > really seem credible.
> 
> We will use Firmware-name in Device Tree.

> For power supply settings, because there may be other device using
> same regulator.

If there are other devices using the same regulator is it more
important that you document it so that it doesn't get disabled by the
other users.

> We plan to define it as an optional property for user to control in
> next release.

I don't see how the regulator would not be required, the device doesn't
function without power.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)