linux-kernel - Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgKUor3XFJI6JcZm@pc636>
Date: Tue, 26 Mar 2024 10:25:54 +0100
From: Uladzislau Rezki <urezki@...il.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@...il.com>, linux-mm@...ck.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Baoquan He <bhe@...hat.com>,
	Lorenzo Stoakes <lstoakes@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Matthew Wilcox <willy@...radead.org>,
	Dave Chinner <david@...morbit.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap_area() if
 vmap is not init

On Tue, Mar 26, 2024 at 08:48:46AM +0100, Heiko Carstens wrote:
> On Sat, Mar 23, 2024 at 03:15:44PM +0100, Uladzislau Rezki (Sony) wrote:
> > During the boot the s390 system triggers "spinlock bad magic" messages
> > if the spinlock debugging is enabled:
> ...
> > Some background. It worked before because the lock that is in question
> > was statically defined and initialized. As of now, the locks and data
> > structures are initialized in the vmalloc_init() function.
> > 
> > To address that issue add the check whether the "vmap_initialized"
> > variable is set, if not find_vmap_area() bails out on entry returning NULL.
> > 
> > Fixes: 72210662c5a2 ("mm: vmalloc: offload free_vmap_area_lock lock")
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> > ---
> >  mm/vmalloc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Thanks for fixing this, and FWIW:
> Acked-by: Heiko Carstens <hca@...ux.ibm.com>
>
You are welcome and thank you!

--
Uladzislau Rezki