linux-kernel - Re: [PATCH v1] usb: typec: tcpm: Correct the PDO counting in pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024032624-drizzle-coaster-c97f@gregkh>
Date: Tue, 26 Mar 2024 10:30:10 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Kyle Tso <kyletso@...gle.com>
Cc: linux@...ck-us.net, heikki.krogerus@...ux.intel.com, badhri@...gle.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Correct the PDO counting in pd_set

On Tue, Mar 19, 2024 at 03:43:37PM +0800, Kyle Tso wrote:
> The index in the loop has already been added one and is equal to the
> number of PDOs to be updated when leaving the loop.

That says what is happening but not the issue that is being addressed.
What is the problem with the number being off by one?  Is this a "crash
the system" or merely "our accounting is wrong"?

thank,

greg k-h