linux-kernel - Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024032639-pope-tiling-340c@gregkh>
Date: Tue, 26 Mar 2024 10:36:12 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Surong Pang <surong.pang@...soc.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Orson.Zhai@...soc.com, Zhiyong.liu@...soc.com,
	Surong.Pang@...il.com
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -39,6 +39,8 @@
>  
>  #include "rndis.h"
>  
> +static int max_out_pkts_per_xfer;
> +static int max_out_size_per_xfer;

Note, this will not work, you can't have device-specific variables as a
single entry, otherwise multiple devices at the same time will not work
at all.

thanks,

greg k-h