linux-kernel - Re: [PATCH 2/2] net: ravb: Always update error counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326094201.GE1108818@ragnatech.se>
Date: Tue, 26 Mar 2024 10:42:01 +0100
From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
To: Paul Barker <paul.barker.ct@...renesas.com>
Cc: Sergey Shtylyov <s.shtylyov@....ru>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ravb: Always update error counters

Hi Paul,

Thanks for your work.

On 2024-03-26 08:37:40 +0000, Paul Barker wrote:
> The error statistics should be updated each time the poll function is
> called, even if the full RX work budget has been consumed. This prevents
> the counts from becoming stuck when RX bandwidth usage is high.
> 
> This also ensures that error counters are not updated after we've
> re-enabled interrupts as that could result in a race condition.
> 
> Also drop an unnecessary space.
> 
> Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver")

Same comment about fixes tag is in patch 1/2.

> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>
> ---
>  drivers/net/ethernet/renesas/ravb_main.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 4f98e4e2badb..a95703948a36 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1339,6 +1339,15 @@ static int ravb_poll(struct napi_struct *napi, int budget)
>  	netif_wake_subqueue(ndev, q);
>  	spin_unlock_irqrestore(&priv->lock, flags);
>  
> +	/* Receive error message handling */
> +	priv->rx_over_errors =  priv->stats[RAVB_BE].rx_over_errors;

While you are dropping spaces s/=  priv/= priv/ here.

> +	if (info->nc_queues)
> +		priv->rx_over_errors += priv->stats[RAVB_NC].rx_over_errors;
> +	if (priv->rx_over_errors != ndev->stats.rx_over_errors)
> +		ndev->stats.rx_over_errors = priv->rx_over_errors;
> +	if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors)
> +		ndev->stats.rx_fifo_errors = priv->rx_fifo_errors;
> +
>  	if (!rearm)
>  		goto out;
>  
> @@ -1355,14 +1364,6 @@ static int ravb_poll(struct napi_struct *napi, int budget)
>  	}
>  	spin_unlock_irqrestore(&priv->lock, flags);
>  
> -	/* Receive error message handling */
> -	priv->rx_over_errors =  priv->stats[RAVB_BE].rx_over_errors;
> -	if (info->nc_queues)
> -		priv->rx_over_errors += priv->stats[RAVB_NC].rx_over_errors;
> -	if (priv->rx_over_errors != ndev->stats.rx_over_errors)
> -		ndev->stats.rx_over_errors = priv->rx_over_errors;
> -	if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors)
> -		ndev->stats.rx_fifo_errors = priv->rx_fifo_errors;
>  out:
>  	return budget - quota;
>  }
> -- 
> 2.44.0
> 

-- 
Kind Regards,
Niklas Söderlund