linux-kernel - Re: [PATCH] irqchip/gic-v3-its: Fix double free on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <661a577c-b4bb-e438-6ba5-6ed90b08649f@huawei.com>
Date: Tue, 26 Mar 2024 17:43:39 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: huangguanrui.hgr <huangguanrui.hgr@...baba-inc.com>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<maz@...nel.org>, <shannon.zhao@...ux.alibaba.com>, <tglx@...utronix.de>
Subject: Re: [PATCH] irqchip/gic-v3-its: Fix double free on error

On 2024/3/22 10:38, huangguanrui.hgr wrote:
> We notice that:
> In its_vpe_irq_domain_alloc, its_vm is from args, But in its_vpe_irq_domain_free,
> its_vm is from domain->host_data.

They *should* point to the same its_vm structure.

> Will these two values be different? For example, when other bugs occur?

Of course they can be different if there are *bugs* but I guess you
won't get any further (e.g., you hit BUG_ON(vm != vpe->its_vm) in
its_vpe_irq_domain_free()). The right thing to do is fixing the bug
rather than papering over it.

Zenghui