linux-kernel - Re: [PATCH v1 1/1] mfd: intel-lpss: Switch over to MSI interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 26 Mar 2024 11:06:38 +0100
From: Mateusz K <mateusz.kaduk@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Lee Jones <lee@...nel.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Switch over to MSI interrupts

I tried the patch that changes PCI_IRQ_LEGACY into PCI_IRQ_ALL_TYPES
and it seems I get some other error now

[    1.477341] intel-lpss 0000:00:15.0: enabling device (0004 -> 0006)
[    1.477466] intel-lpss 0000:00:15.0: can't derive routing for PCI INT A
[    1.477468] intel-lpss 0000:00:15.0: PCI INT A: not connected
[    1.477488] intel-lpss 0000:00:15.0: probe with driver intel-lpss
failed with error -2147483648
[    1.489572] intel-lpss 0000:00:15.2: enabling device (0004 -> 0006)
[    1.489688] intel-lpss 0000:00:15.2: can't derive routing for PCI INT C
[    1.489689] intel-lpss 0000:00:15.2: PCI INT C: not connected
[    1.489715] intel-lpss 0000:00:15.2: probe with driver intel-lpss
failed with error -2147483648
[    1.501886] intel-lpss 0000:00:19.0: enabling device (0004 -> 0006)
[    1.502034] intel-lpss 0000:00:19.0: can't derive routing for PCI INT A
[    1.502036] intel-lpss 0000:00:19.0: PCI INT A: not connected
[    1.502067] intel-lpss 0000:00:19.0: probe with driver intel-lpss
failed with error -2147483648
[    1.514288] intel-lpss 0000:00:19.1: enabling device (0004 -> 0006)
[    1.514535] intel-lpss 0000:00:19.1: can't derive routing for PCI INT B
[    1.514538] intel-lpss 0000:00:19.1: PCI INT B: not connected
[    1.514570] intel-lpss 0000:00:19.1: probe with driver intel-lpss
failed with error -2147483648
[    1.526291] intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006)
[    1.526555] intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A
[    1.526557] intel-lpss 0000:00:1e.0: PCI INT A: not connected
[    1.526604] intel-lpss 0000:00:1e.0: probe with driver intel-lpss
failed with error -2147483648
[    1.538130] intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006)
[    1.538233] intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D
[    1.538235] intel-lpss 0000:00:1e.3: PCI INT D: not connected
[    1.538253] intel-lpss 0000:00:1e.3: probe with driver intel-lpss
failed with error -2147483648

Mateusz

On Mon, Mar 25, 2024 at 10:19 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> [+bcc Mateusz]
>
> On Tue, Mar 12, 2024 at 06:59:05PM +0200, Andy Shevchenko wrote:
> > Some devices support MSI interrupts. Let's at least try to use them in
> > platforms that provide MSI capability.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  drivers/mfd/intel-lpss-pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> > index 8c00e0c695c5..c36a101df7be 100644
> > --- a/drivers/mfd/intel-lpss-pci.c
> > +++ b/drivers/mfd/intel-lpss-pci.c
> > @@ -54,7 +54,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
> >       if (ret)
> >               return ret;
> >
> > -     ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> > +     ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> >       if (ret < 0)
> >               return ret;
>
> I guess at least some of these devices do support INTx, since we
> always used INTx previously, right?
>
> There are a bunch of bug reports complaining about a lack of _PRT
> entries for them, e.g., these from
> https://bugzilla.kernel.org/show_bug.cgi?id=212261#c24:
>
>   intel-lpss 0000:00:15.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:15.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:15.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:15.0 failed with error -22
>   intel-lpss 0000:00:15.2: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:15.2: can't derive routing for PCI INT C
>   intel-lpss 0000:00:15.2: PCI INT C: not connected
>   intel-lpss: probe of 0000:00:15.2 failed with error -22
>   intel-lpss 0000:00:19.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:19.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:19.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:19.0 failed with error -22
>   intel-lpss 0000:00:19.1: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:19.1: can't derive routing for PCI INT B
>   intel-lpss 0000:00:19.1: PCI INT B: not connected
>   intel-lpss: probe of 0000:00:19.1 failed with error -22
>   intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:1e.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:1e.0 failed with error -22
>   intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D
>   intel-lpss 0000:00:1e.3: PCI INT D: not connected
>   intel-lpss: probe of 0000:00:1e.3 failed with error -22
>
> I don't know if these are a _PRT bug (I think if a device advertises a
> non-zero Interrupt Pin, the _PRT should tell us how it is routed), or
> possibly a device bug (advertises Interrupt Pin == INTA when it should
> advertise "no INTx used"), or something else.
>
> Bjorn