linux-kernel - Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 10:52:45 +0000
From: 庞苏荣 (Surong Pang) <surong.pang@...soc.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        翟京 (Orson Zhai) <Orson.Zhai@...soc.com>,
        刘智勇 (Zhiyong Liu) <Zhiyong.Liu@...soc.com>,
        "Surong.Pang@...il.com" <Surong.Pang@...il.com>
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

Dear Greg,

These values are just used to recorded water mask of received packages per transfer.
Just to print the water mask information, they can be deleted.

Anyway, if rndis will be deleted entirely, this patch can be abandoned.

> 
> 
> On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> > --- a/drivers/usb/gadget/function/rndis.c
> > +++ b/drivers/usb/gadget/function/rndis.c
> > @@ -39,6 +39,8 @@
> >
> >  #include "rndis.h"
> >
> > +static int max_out_pkts_per_xfer;
> > +static int max_out_size_per_xfer;
> 
> Note, this will not work, you can't have device-specific variables as a single entry, otherwise multiple devices at the same time will not
> work at all.
> 
> thanks,
> 
> greg k-h