linux-kernel - Re: [PATCH v6 3/5] thermal/cpufreq: Remove arch_update_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 17:16:51 +0530
From: Dhruva Gole <d-gole@...com>
To: Vincent Guittot <vincent.guittot@...aro.org>
CC: <linux@...linux.org.uk>, <catalin.marinas@....com>, <will@...nel.org>,
        <sudeep.holla@....com>, <rafael@...nel.org>, <viresh.kumar@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <mingo@...hat.com>, <peterz@...radead.org>,
        <juri.lelli@...hat.com>, <dietmar.eggemann@....com>,
        <rostedt@...dmis.org>, <bsegall@...gle.com>, <mgorman@...e.de>,
        <bristot@...hat.com>, <vschneid@...hat.com>, <lukasz.luba@....com>,
        <rui.zhang@...el.com>, <mhiramat@...nel.org>,
        <daniel.lezcano@...aro.org>, <amit.kachhap@...il.com>,
        <corbet@....net>, <gregkh@...uxfoundation.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v6 3/5] thermal/cpufreq: Remove
 arch_update_thermal_pressure()

Hi,

On Mar 26, 2024 at 10:16:14 +0100, Vincent Guittot wrote:
> arch_update_thermal_pressure() aims to update fast changing signal which
> should be averaged using PELT filtering before being provided to the
> scheduler which can't make smart use of fast changing signal.
> cpufreq now provides the maximum freq_qos pressure on the capacity to the
> scheduler, which includes cpufreq cooling device. Remove the call to
> arch_update_thermal_pressure() in cpufreq cooling device as this is
> handled by cpufreq_get_pressure().
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@....com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> Tested-by: Lukasz Luba <lukasz.luba@....com>
> ---

Makes sense,
Reviewed-by: Dhruva Gole <d-gole@...com>


-- 
Best regards,
Dhruva