[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<DU0PR04MB941779A13906E00ACAC987AA88352@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Tue, 26 Mar 2024 01:26:01 +0000
From: Peng Fan <peng.fan@....com>
To: Thomas Gleixner <tglx@...utronix.de>, Jason Gunthorpe <jgg@...pe.ca>,
"Peng Fan (OSS)" <peng.fan@....nxp.com>
CC: Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>, Joerg
Roedel <joro@...tes.org>, Marc Zyngier <maz@...nel.org>, Bixuan Cui
<cuibixuan@...wei.com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "iommu@...ts.linux.dev"
<iommu@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume
> Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: support suspend/resume
>
> On Mon, Mar 25 2024 at 10:48, Jason Gunthorpe wrote:
> > On Sun, Mar 24, 2024 at 08:29:00PM +0800, Peng Fan (OSS) wrote:
> >> +static void arm_smmu_resume_unique_irqs(struct arm_smmu_device
> >> +*smmu) {
> >> + struct device *dev = smmu->dev;
> >> + struct msi_desc *desc;
> >> + struct msi_msg msg;
> >> +
> >> + if (!dev->msi.domain)
> >> + return;
> >> +
> >> + desc = irq_get_msi_desc(smmu->evtq.q.irq);
> >> + if (desc) {
> >> + get_cached_msi_msg(smmu->evtq.q.irq, &msg);
> >> + arm_smmu_write_msi_msg(desc, &msg);
> >> + }
> >> +
> >> + desc = irq_get_msi_desc(smmu->gerr_irq);
> >> + if (desc) {
> >> + get_cached_msi_msg(smmu->gerr_irq, &msg);
> >> + arm_smmu_write_msi_msg(desc, &msg);
> >> + }
> >> +
> >> + if (smmu->features & ARM_SMMU_FEAT_PRI) {
> >> + desc = irq_get_msi_desc(smmu->priq.q.irq);
> >> + if (desc) {
> >> + get_cached_msi_msg(smmu->priq.q.irq, &msg);
> >> + arm_smmu_write_msi_msg(desc, &msg);
> >> + }
> >> + }
> >> +}
> >
> > I wonder if this should be done instead by converting the driver away
> > from platform MSI to the new MSI mechanism?
>
> There is work in progress for that. Should come around in the next weeks.
Then I need to wait for your patches, and rebase this patchset, or could
the non-msi part be reviewed first?
Thanks,
Peng.
Powered by blists - more mailing lists