linux-kernel - Re: [PATCH 3/3] dt-bindings: hsi: omap-ssi: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 14:34:32 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Tony Lindgren <tony@...mide.com>, devicetree@...r.kernel.org, linux-omap@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: hsi: omap-ssi: convert to YAML

Hi,

On Tue, Mar 26, 2024 at 08:26:54AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 22:45, Sebastian Reichel wrote:
> > Convert the legacy txt binding to modern YAML.
> > No semantic change.
> 
> You deprecated a property: ti,hwmods. Also will be one more change:
> ti,ssi-cawake-gpio->gpios

and I will introduce a simple bus binding for referencing the
peripheral. I added a list to the commit message for v2.

> >  Documentation/devicetree/bindings/hsi/omap-ssi.txt | 102 -----------
> >  .../devicetree/bindings/hsi/ti,omap-ssi.yaml       | 196 +++++++++++++++++++++
> >  2 files changed, 196 insertions(+), 102 deletions(-)

[...]

> > +patternProperties:
> > +  "[hs]si-port@[0-9a-f]+":
> 
> Does anything actually depends on the name? Can these be "port@[0-9a-f]+"?

That should work. The Linux driver is looping over all child nodes
and checking the compatible.

[...]

> > +      ti,ssi-cawake-gpio:
> 
> ti,ssi-cawake-gpios

mh, the kernel supports the extra s since 2016. I guess that should
be good enough. I will fix it in v2.

All other comments will be fixed in v2.

Thanks for the review,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)