linux-kernel - Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79bca118-5027-4153-9fea-bda4c5ad6edb@kernel.org>
Date: Tue, 26 Mar 2024 22:40:35 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: John Garry <john.g.garry@...cle.com>, Yihang Li <liyihang9@...wei.com>,
 yanaijie@...wei.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
 chenxiang66@...ilicon.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linuxarm@...wei.com, prime.zeng@...wei.com, yangxingui@...wei.com
Subject: Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to
 ARCH_DMA_MINALIGN

On 3/26/24 22:32, John Garry wrote:
>> John,
>>
>> Unrelated to this patch, but I wonder if the GFP_KERNEL used here shouldn't be
>> GFP_NOIO... Is this ever called in the IO path or error recovery ?
>>
> 
> These should not be called in the IO path - as they are management 
> functions. But I am quite confident that they can be called in SCSI 
> error handling (for libsas).

So it sounds like GFP_NOIO would be a lot safer...

> 
> Thanks,
> John

-- 
Damien Le Moal
Western Digital Research