linux-kernel - Re: [PATCH 07/10] rust: alloc: update `VecExt` to take allocation flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <L8Btmo6IhqMHoSXiTDQ-avI42EPw1WUkSiIshVgNZ4gvBZJEYkNL2Ag3hQ0dLEwF_c1FnLTG1rY9G4UTHAbRvxuAxiN-Dk5vGryaNvKD450=@proton.me>
Date: Tue, 26 Mar 2024 13:58:33 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Wedson Almeida Filho <wedsonaf@...il.com>
Cc: Boqun Feng <boqun.feng@...il.com>, rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>, linux-kernel@...r.kernel.org, Wedson Almeida Filho <walmeida@...rosoft.com>
Subject: Re: [PATCH 07/10] rust: alloc: update `VecExt` to take allocation flags

On 25.03.24 20:54, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@...rosoft.com>
> 
> We also rename the methods by removing the `try_` prefix since the names
> are available due to our usage of the `no_global_oom_handling` config
> when building the `alloc` crate.
> 
> Signed-off-by: Wedson Almeida Filho <walmeida@...rosoft.com>
> ---
>   rust/kernel/alloc/vecext.rs  | 106 ++++++++++++++++++++++++++++-------
>   rust/kernel/lib.rs           |   1 -
>   rust/kernel/str.rs           |   6 +-
>   rust/kernel/types.rs         |   4 +-
>   samples/rust/rust_minimal.rs |   6 +-
>   5 files changed, 95 insertions(+), 28 deletions(-)

With Boqun's change:

Reviewed-by: Benno Lossin <benno.lossin@...ton.me>

One thing that we might consider in the future would be to create
our own `Extend` trait to allow extending a Vec with any iterator.

-- 
Cheers,
Benno