linux-kernel - Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024032616-dumping-blustery-aeb2@gregkh>
Date: Tue, 26 Mar 2024 15:07:27 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: 庞苏荣 (Surong Pang) <surong.pang@...soc.com>
Cc: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	翟京 (Orson Zhai) <Orson.Zhai@...soc.com>,
	刘智勇 (Zhiyong Liu) <Zhiyong.Liu@...soc.com>,
	"Surong.Pang@...il.com" <Surong.Pang@...il.com>
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis

On Tue, Mar 26, 2024 at 10:47:16AM +0000, 庞苏荣 (Surong Pang) wrote:
> Dear Greg，
> Share Android Phone internet to Windows PC via USB still need the rndis feature.

What supported Windows PC still only has rndis and not cdc-ncm support?
Or the other USB networking driver support built in?  Windows has
deprecated RNDIS for a good reason, let's not continue to insist on
using insecure protocols please.

> OK, if rndis will be deleted entirely, this patch can be abandoned.

Eventually, yes, but as is, your patch can't be taken given the quick
review I already provided.

If you can show that there are Windows systems that only have RNDIS
support, and need this increased speed (i.e. that they can also support
the speedup), and fix up the other issues, then we can review your new
submission.  But please provide that proof when you do so.

thanks,

greg k-h