linux-kernel - Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240326140759.GGZgLWv3UZVpHZ5c98@fat_crate.local>
Date: Tue, 26 Mar 2024 15:07:59 +0100
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: linux-edac <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"anthony s . k ." <akira.2020@...tonmail.com>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled

On Tue, Mar 26, 2024 at 09:41:41AM -0400, Yazen Ghannam wrote:
> This isn't true which is why the module doesn't fail to load if debugfs
> is not available.

How useful is this thing really without debugfs to dump records?

> This was my first thought too. However, besides not true as stated
> above, this also leaves the issue open for others to hit.

The others to hit? I don't get that part.

> I think the fix below (not tested) would be more appropriate.
> 
> What do you think?

Sure, remove my fix and send me a tested version of yours and I'll swap
them if the driver is useful without debugfs...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette