linux-kernel - Re: [PATCH 00/19] ACPI: store owner from modules with acpi_bus_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hEiKJJWn-TVoyL6DEbCcMpL39_q+HLG_YZyjf9g29CXA@mail.gmail.com>
Date: Wed, 27 Mar 2024 14:16:46 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Robert Moore <robert.moore@...el.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Benson Leung <bleung@...omium.org>, 
	Tzung-Bi Shih <tzungbi@...nel.org>, Corentin Chary <corentin.chary@...il.com>, 
	"Luke D. Jones" <luke@...nes.dev>, Hans de Goede <hdegoede@...hat.com>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>, Daniel Oliveira Nascimento <don@...t.com.br>, 
	Pali Rohár <pali@...nel.org>, 
	Matan Ziv-Av <matan@...alib.org>, Mattia Dongili <malattia@...ux.it>, 
	Azael Avalos <coproscefalo@...il.com>, Richard Cochran <richardcochran@...il.com>, 
	Jeff Sipek <jsipek@...are.com>, Ajay Kaher <akaher@...are.com>, 
	Alexey Makhalov <amakhalov@...are.com>, VMware PV-Drivers Reviewers <pv-drivers@...are.com>, 
	"Theodore Ts'o" <tytso@....edu>, "Jason A. Donenfeld" <Jason@...c4.com>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, acpica-devel@...ts.linux.dev, 
	linux-input@...r.kernel.org, netdev@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 00/19] ACPI: store owner from modules with acpi_bus_register_driver()

On Wed, Mar 27, 2024 at 8:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Merging
> =======
> All further patches depend on the first amba patch, therefore please ack
> and this should go via one tree: ACPI?
>
> Description
> ===========
> Modules registering driver with acpi_bus_register_driver() often forget to
> set .owner field.
>
> Solve the problem by moving this task away from the drivers to the core
> amba bus code, just like we did for platform_driver in commit
> 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (19):
>       ACPI: store owner from modules with acpi_bus_register_driver()
>       Input: atlas: - drop owner assignment
>       net: fjes: drop owner assignment
>       platform: chrome: drop owner assignment
>       platform: asus-laptop: drop owner assignment
>       platform: classmate-laptop: drop owner assignment
>       platform/x86/dell: drop owner assignment
>       platform/x86/eeepc: drop owner assignment
>       platform/x86/intel/rst: drop owner assignment
>       platform/x86/intel/smartconnect: drop owner assignment
>       platform/x86/lg-laptop: drop owner assignment
>       platform/x86/sony-laptop: drop owner assignment
>       platform/x86/toshiba_acpi: drop owner assignment
>       platform/x86/toshiba_bluetooth: drop owner assignment
>       platform/x86/toshiba_haps: drop owner assignment
>       platform/x86/wireless-hotkey: drop owner assignment
>       ptp: vmw: drop owner assignment
>       virt: vmgenid: drop owner assignment
>       ACPI: drop redundant owner from acpi_driver

I definitely like this, so

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

for the series and I can pick it up if people agree.

Thanks!