linux-kernel - Re: [PATCH v2 2/2] net: usb: ax88179_178a: non necessary second random mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240327160052.GP403975@kernel.org>
Date: Wed, 27 Mar 2024 16:00:52 +0000
From: Simon Horman <horms@...nel.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: dave.stevenson@...pberrypi.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	pabeni@...hat.com, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] net: usb: ax88179_178a: non necessary second
 random mac address

On Tue, Mar 26, 2024 at 05:31:07PM +0100, Jose Ignacio Tornos Martinez wrote:
> If the mac address can not be read from the device registers or the
> devicetree, a random address is generated, but this was already done from
> usbnet_probe, so it is not necessary to call eth_hw_addr_random from here
> again to generate another random address.
> 
> Indeed, when reset was also executed from bind, generate another random mac
> address invalidated the check from usbnet_probe to configure if the assigned
> mac address for the interface was random or not, because it is comparing
> with the initial generated random address. Now, with only a reset from open
> operation, it is just a harmless simplification.
> 
> cc: stable@...r.kernel.org # 6.6+
> Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
> ---
> V1 -> V2:
> - Split the fix and the improvement in two patches and keep curly-brackets
> as Simon Horman suggests.

Hi Jose,

Thanks for splitting the patches.
They look good, but there are a few process issues.
Sorry for not being clearer in my previous email.

As the 2nd patch of the series is not a fix it:
- Should not have a fixes tag
- Should not be sent to stable
- Should be targeted at the net-next tree rather than the net tree

As the granularity of patch handling on netdev is generally at the
patchset level I believe that this means that you need to separately,
in different, new, email threads, repost:

1. Patch 1/2 of this series, targeted at net, with a Fixes tag

   [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address

2. Patch 2/2 of this series, targeted at net-next, without a Fixes tag

   [PATCH net-next v3] et: usb: ax88179_178a: non necessary second random mac address

Also, please be sure to wait 24 hours since the posting of this patch-set
before reposting.

Some more information can be found here:
https://docs.kernel.org/process/maintainer-netdev.html

..

--
pw-bot: changes-requested