[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e4ba58bc-fa5b-4ece-8906-f7cc7cb5b0f4@sirena.org.uk>
Date: Wed, 27 Mar 2024 14:58:50 +0000
From: Mark Brown <broonie@...nel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@....com>
Cc: alsa-devel@...a-project.org, venkataprasad.potturu@....com,
Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Syed Saba Kareem <Syed.SabaKareem@....com>,
Jarkko Nikula <jarkko.nikula@...mer.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: amd: acp: fix for acp_init function error
handling
On Wed, Mar 27, 2024 at 04:16:52PM +0530, Vijendar Mukunda wrote:
> @@ -115,7 +115,10 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
> goto unregister_dmic_dev;
> }
>
> - acp_init(chip);
> + ret = acp_init(chip);
> + if (ret)
> + return ret;
> +
The return check is good but shouldn't this be a 'goto
unregister_dmic_dev' like the above case so we do cleanup?
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists