linux-kernel - Re: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240327154316.GA3453016-robh@kernel.org>
Date: Wed, 27 Mar 2024 10:43:16 -0500
From: Rob Herring <robh@...nel.org>
To: Raymond Hackley <raymondhackley@...tonmail.com>
Cc: linux-kernel@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Stephan Gerhold <stephan@...hold.net>,
	Nikita Travkin <nikita@...n.ru>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna

On Tue, Mar 26, 2024 at 02:12:58PM +0000, Raymond Hackley wrote:
> Document common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices below:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H  (msm8216-samsung-fortuna3g)
> - SM-G530W  (msm8916-gprimeltecan)

Commit messages should answer "why?". Why do you need this?

Please test this binding change against your dts changes. I think you 
will find it fails.

> 
> Signed-off-by: Raymond Hackley <raymondhackley@...tonmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 66beaac60e1d..2db776d78d22 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -204,6 +204,7 @@ properties:
>                - samsung,a5u-eur
>                - samsung,e5
>                - samsung,e7
> +              - samsung,fortuna
>                - samsung,fortuna3g
>                - samsung,gprimeltecan
>                - samsung,grandmax
> -- 
> 2.39.2
> 
>