linux-kernel - Re: [PATCH] check-uapi: added arm64 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <D04QMF0IN7CH.2DPU99RSEZJDM@jmoon.dev>
Date: Wed, 27 Mar 2024 18:17:48 +0000
From: John Moon <john@...on.dev>
To: Jackie Liu <liuyun01@...inos.cn>, masahiroy@...nel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] check-uapi: added arm64 support

On Wed Mar 27, 2024 at 3:35 AM PDT, Jackie Liu wrote:
> By default, `uname -m` of arm64 will return aarch64, and the correct source code
> directory cannot be obtained when the script is executed. In order to solve this
> problem, it is necessary to correct ARCH=arm64 when aarch64.
>
> Signed-off-by: Jackie Liu <liuyun01@...inos.cn>
> ---
>  scripts/check-uapi.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/check-uapi.sh b/scripts/check-uapi.sh
> index 955581735cb3..1c39d13b90b8 100755
> --- a/scripts/check-uapi.sh
> +++ b/scripts/check-uapi.sh
> @@ -408,6 +408,8 @@ check_deps() {
>  	ARCH="${ARCH:-$(uname -m)}"
>  	if [ "$ARCH" = "x86_64" ]; then
>  		ARCH="x86"
> +	elif [ "$ARCH" = "aarch64" ]; then
> +		ARCH="arm64"
>  	fi
>
>  	local -r abidiff_min_version="2.4"
> --
> 2.33.0

Good catch. Looks good to me!

Reviewed-by: John Moon <john@...on.dev>