linux-kernel - Re: [PATCH] watchdog: mtx-1: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97006bea-f233-43c9-a038-f2a71ff7c443@roeck-us.net>
Date: Wed, 27 Mar 2024 11:36:46 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: mtx-1: drop driver owner assignment

On Wed, Mar 27, 2024 at 06:46:38PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/mtx-1_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 152e41ecbb14..06756135033d 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -236,7 +236,6 @@ static struct platform_driver mtx1_wdt_driver = {
>  	.probe = mtx1_wdt_probe,
>  	.remove_new = mtx1_wdt_remove,
>  	.driver.name = "mtx1-wdt",
> -	.driver.owner = THIS_MODULE,
>  };
>  
>  module_platform_driver(mtx1_wdt_driver);
> -- 
> 2.34.1
>