[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240327-hsi-dt-binding-v2-0-110fab4c32ae@collabora.com>
Date: Wed, 27 Mar 2024 20:11:31 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Sebastian Reichel <sre@...nel.org>
Cc: Tony Lindgren <tony@...mide.com>, devicetree@...r.kernel.org,
linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: [PATCH v2 0/7] Convert MIPI HSI DT bindings to YAML
Hi,
This converts all MIPI HSI subystem DT bindings to YAML.
I ran the following tests:
1. Check binding files
make -j$(nproc) dt_binding_check DT_SCHEMA_FILES=/hsi/
2. Check OMAP3 and nokia-modem DT
make -j$(nproc) CHECK_DTBS=y ti/omap/omap3-n900.dtb ti/omap/omap3-n950.dtb ti/omap/omap3-n9.dtb
3. Check OMAP4 DT (OMAP4 HSI is not used upstream, so one is enough)
make -j$(nproc) CHECK_DTBS=y ti/omap/omap4-droid4-xt894.dtb
FWIW I noticed a lots of warnings for OMAP3 & OMAP4, but
none related to HSI/SSI.
Greetings,
-- Sebastian
---
Changes in v2:
- Link to v1: https://lore.kernel.org/r/20240325-hsi-dt-binding-v1-0-88e8e97c3aae@collabora.com
- fixed, that "hsi-client" is not a generic node name
- hsi-client.yaml needs to use oneOf instead of anyOf for the hsi-mode requirement
- change nokia-modem.yaml to nokia,modem.yaml
- add hsi-channel-ids constraints to nokia modem binding; I had to also add
$ref: /schemas/types.yaml#/definitions/uint32-array again, because otherwise
the tooling complained about the example DT having not enough IDs for
[[0], [1], [2], [3]]. It does properly inherit the hsi-client.yaml, though.
If I drop the constraints from the modem binding and change the generic binding
to require 5 IDs, the tooling does complain. So I think this is a bug in the DT
checking tool. For now readding the ref again seems to be a good enough workaround.
- changed node name to "modem" for the nokia modem
- renamed ti,ssi-cawake-gpio to ti,ssi-cawake-gpios
- changed ssi-port@ & hsi-port@ to just port@
- dropped blank line in omap-ssi binding
- moved additionalProperties before the examples in omap-ssi binding
- fixed indentation for the omaps-ssi example in the binding
- added patches fixing up OMAP3 & OMAP4 DT files according to the latest changes
---
Sebastian Reichel (7):
dt-bindings: hsi: hsi-client: convert to YAML
dt-bindings: hsi: nokia-modem: convert to YAML
dt-bindings: hsi: omap-ssi: convert to YAML
ARM: dts: omap4: fix hsi-port node name
ARM: dts: omap3: fix ssi-port node name
ARM: dts: omap3: fix ti,ssi-cawake-gpio property name
ARM: dts: omap3: use generic node name for hsi clients
.../devicetree/bindings/hsi/client-devices.txt | 44 -----
.../devicetree/bindings/hsi/hsi-client.yaml | 81 ++++++++++
.../devicetree/bindings/hsi/nokia,modem.yaml | 106 ++++++++++++
.../devicetree/bindings/hsi/nokia-modem.txt | 59 -------
Documentation/devicetree/bindings/hsi/omap-ssi.txt | 102 ------------
.../devicetree/bindings/hsi/ti,omap-ssi.yaml | 177 +++++++++++++++++++++
arch/arm/boot/dts/ti/omap/omap3-n900.dts | 4 +-
arch/arm/boot/dts/ti/omap/omap3-n950-n9.dtsi | 4 +-
arch/arm/boot/dts/ti/omap/omap3.dtsi | 4 +-
arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 4 +-
10 files changed, 372 insertions(+), 213 deletions(-)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240325-hsi-dt-binding-a5d662e3d601
Best regards,
--
Sebastian Reichel <sebastian.reichel@...labora.com>
Powered by blists - more mailing lists