[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e1d8d30f-483a-4e3b-882c-147cea40c532@linaro.org>
Date: Wed, 27 Mar 2024 21:48:10 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Thomas Weißschuh <linux@...ssschuh.net>,
Sebastian Reichel <sre@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH v2 1/4] power: supply: mm8013: fix "not charging"
detection
On 3.03.2024 4:31 PM, Thomas Weißschuh wrote:
> The charge_behaviours property is meant as a control-knob that can be
> changed by the user.
>
> Page 23 of [0] which documents the flag CHG_INH as follows:
>
> CHG_INH : Charge Inhibit When the current is more than or equal to charge
> threshold current,
> charge inhibit temperature (upper/lower limit) :1
> charge permission temperature or the current is
> less than charge threshold current :0
>
> So this is pure read-only information which is better represented as
> POWER_SUPPLY_STATUS_NOT_CHARGING.
>
> [0] https://product.minebeamitsumi.com/en/product/category/ics/battery/fuel_gauge/parts/download/__icsFiles/afieldfile/2023/07/12/1_download_01_12.pdf
>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
The patch is now queued, so I won't leave any additional tags,
but thanks for taking care of this, Thomas!
Konrad
Powered by blists - more mailing lists