linux-kernel - Re: [PATCH v3 12/14] drm/amd/display: Use ARCH_HAS_KERNEL_FPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240327142516.e4b1f9ba6e2ec7bc300e4d58@linux-foundation.org>
Date: Wed, 27 Mar 2024 14:25:16 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Samuel Holland <samuel.holland@...ive.com>
Cc: linux-arm-kernel@...ts.infradead.org, x86@...nel.org,
 linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, Christoph
 Hellwig <hch@....de>, loongarch@...ts.linux.dev,
 amd-gfx@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>
Subject: Re: [PATCH v3 12/14] drm/amd/display: Use
 ARCH_HAS_KERNEL_FPU_SUPPORT

On Wed, 27 Mar 2024 13:00:43 -0700 Samuel Holland <samuel.holland@...ive.com> wrote:

> Now that all previously-supported architectures select
> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead
> of the existing list of architectures. It can also take advantage of the
> common kernel-mode FPU API and method of adjusting CFLAGS.
> 
> ...
>
> @@ -87,16 +78,9 @@ void dc_fpu_begin(const char *function_name, const int line)
>  	WARN_ON_ONCE(!in_task());
>  	preempt_disable();
>  	depth = __this_cpu_inc_return(fpu_recursion_depth);
> -
>  	if (depth == 1) {
> -#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
> +		BUG_ON(!kernel_fpu_available());
>  		kernel_fpu_begin();

For some reason kernel_fpu_available() was undefined in my x86_64
allmodconfig build.  I just removed the statement.