linux-kernel - Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+GJov6wuRDu2JiUsw0qtWehpbUPnxM=fK-dJxVMtOr0TejP+A@mail.gmail.com>
Date: Wed, 27 Mar 2024 19:32:20 -0400
From: Rae Moar <rmoar@...gle.com>
To: David Gow <davidgow@...gle.com>
Cc: SeongJae Park <sj@...nel.org>, Mark Brown <broonie@...nel.org>, 
	Johannes Berg <johannes.berg@...el.com>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS_DEPRECATED for --alltests

On Tue, Mar 26, 2024 at 6:07 AM David Gow <davidgow@...gle.com> wrote:
>
> This is required, as CONFIG_DAMON_DEBUGFS is enabled, and --alltests UML
> builds will fail due to the missing config option otherwise.
>
> Fixes: f4cba4bf6777 ("mm/damon: rename CONFIG_DAMON_DBGFS to DAMON_DBGFS_DEPRECATED")
> Signed-off-by: David Gow <davidgow@...gle.com>

Hello!

This looks good to me. And it takes away the issue with
CONFIG_DAMON_DBGFS. But since this is deprecated now, should we move
to the DAMON sysfs tests instead in the future? No need to let that
stall this patch though.

Reviewed-by: Rae Moar <rmoar@...gle.com>

Thanks!
-Rae

> ---
>
> This is breaking all UML alltests builds, so we'd like to fix it sooner
> rather than later. SeongJae, would you rather take this yourself, or can
> we push it alongside any other KUnit fixes?
>
> Johannes: Does this conflict with the CONFIG_NETDEVICES / CONFIG_WLAN
> fixes to all_tests.config? I'd assume not, but I'm happy to take them
> via KUnit if you'd prefer anyway.
>
> Thanks,
> -- David
>
> ---
>  tools/testing/kunit/configs/all_tests.config | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> index aa5ec149f96c..f388742cf266 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -38,6 +38,7 @@ CONFIG_DAMON_VADDR=y
>  CONFIG_DAMON_PADDR=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_DAMON_DBGFS=y
> +CONFIG_DAMON_DBGFS_DEPRECATED=y
>
>  CONFIG_REGMAP_BUILD=y
>
> --
> 2.44.0.396.g6e790dbe36-goog
>