linux-kernel - Re: [PATCH v2 1/1] usb: typec: ucsi: Check capabilities before cable and identity discovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240327014602.GB2136359@hu-bjorande-lv.qualcomm.com>
Date: Tue, 26 Mar 2024 18:46:02 -0700
From: Bjorn Andersson <quic_bjorande@...cinc.com>
To: Jameson Thies <jthies@...gle.com>
CC: <heikki.krogerus@...ux.intel.com>, <linux-usb@...r.kernel.org>,
        <pmalani@...omium.org>, <bleung@...gle.com>,
        <abhishekpandit@...omium.org>, <andersson@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <fabrice.gasnier@...s.st.com>,
        <gregkh@...uxfoundation.org>, <hdegoede@...hat.com>,
        <neil.armstrong@...aro.org>, <rajaram.regupathy@...el.com>,
        <saranya.gopal@...el.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] usb: typec: ucsi: Check capabilities before cable
 and identity discovery

On Fri, Mar 15, 2024 at 05:18:35PM +0000, Jameson Thies wrote:
> Check the UCSI_CAP_GET_PD_MESSAGE bit before sending GET_PD_MESSAGE to
> discover partner and cable identity, check UCSI_CAP_CABLE_DETAILS before
> sending GET_CABLE_PROPERTY to discover the cable and check
> UCSI_CAP_ALT_MODE_DETAILS before registering the a cable plug. Additionally,
> move 8 bits from reserved_1 to features in the ucsi_capability struct. This
> makes the field 16 bits, still 8 short of the 24 bits allocated for it in
> UCSI v3.0, but it will not overflow because UCSI only defines 14 bits in
> bmOptionalFeatures.
> 
> Fixes: 38ca416597b0 ("usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY")
> Link: https://lore.kernel.org/linux-usb/44e8142f-d9b3-487b-83fe-39deadddb492@linaro.org
> Suggested-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Jameson Thies <jthies@...gle.com>

Thanks you, Jameson, this resolve the regression I ran into on
qcs6490-rb3gen2 as well.

Tested-by: Bjorn Andersson <quic_bjorande@...cinc.com> # QCS6490 Rb3Gen2

Regards,
Bjorn