linux-kernel - Re: [PATCH] selftests: iommu: add config needed for iommufd_fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 27 Mar 2024 15:14:25 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 iommu@...ts.linux.dev, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Kevin Tian <kevin.tian@...el.com>,
 Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: iommu: add config needed for iommufd_fail_nth

On 3/26/24 8:03 PM, Jason Gunthorpe wrote:
> On Tue, Mar 26, 2024 at 06:09:34PM +0500, Muhammad Usama Anjum wrote:
>> Even after applying this config patch and following snippet (which doesn't
>> terminate the program if mmap doesn't allocate exactly as the hint), I'm
>> finding failed tests.
>>
>> @@ -1746,7 +1748,7 @@ FIXTURE_SETUP(iommufd_dirty_tracking)
>>         assert((uintptr_t)self->buffer % HUGEPAGE_SIZE == 0);
>>         vrc = mmap(self->buffer, variant->buffer_size, PROT_READ | PROT_WRITE,
>>                    mmap_flags, -1, 0);
>> -       assert(vrc == self->buffer);
>> +       assert(vrc == self->buffer);// ???
>>
>> On x86:
>> # Totals: pass:176 fail:4 xfail:0 xpass:0 skip:0 error:0
>> On ARM64:
>> # Totals: pass:166 fail:14 xfail:0 xpass:0 skip:0 error:0
>>
>> The log files are attached.
> 
> You probably don't have enough transparent huge pages available to the process
> 
>       echo 1024 > /proc/sys/vm/nr_hugepages
After making huge pages available, the iommufd test always passed on x86.
But there are still failures on arm64. I'm looking into the failures.

cat /proc/sys/vm/nr_hugepages
1024
/iommufd
..
# Totals: pass:166 fail:14 xfail:0 xpass:0 skip:0 error:0

> 
> Jason
> 

-- 
BR,
Muhammad Usama Anjum
View attachment "iommufd_arm.log" of type "text/x-log" (34970 bytes)