linux-kernel - Re: [PATCH v3] staging: media: remove duplicate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240327103446.45lw5zjghwwcu27h@basti-XPS-13-9310>
Date: Wed, 27 Mar 2024 11:34:46 +0100
From: Sebastian Fricke <sebastian.fricke@...labora.com>
To: coolrrsh@...il.com
Cc: slongerbeam@...il.com, p.zabel@...gutronix.de, mchehab@...nel.org,
	gregkh@...uxfoundation.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	linux-imx@....com, linux-media@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] staging: media: remove duplicate line

Hey Rajeshwar,

On 27.03.2024 08:03, coolrrsh@...il.com wrote:
>From: Rajeshwar R Shinde <coolrrsh@...il.com>
>
>The kernel configuration VIDEO_DEV is defined twice in Kconfig.
>Thus, the redundant code is removed.
>
>Signed-off-by: Rajeshwar R Shinde <coolrrsh@...il.com>
>
>---
>v1->v2
>changed the commit message
>v2->v3
>changed the subject

The subject line isn't any better than before. Lets look at some
accepted examples together:

24d9cb143013 media: staging: imx: controls are from another device, mark this
67673ed55084 media: staging/imx: rearrange group id to take in account IPU
483fe862488f9 staging: media: imx: Merge VIDEO_IMX_CSI into VIDEO_IMX_MEDIA
9958d30f38b96 media: Kconfig: cleanup VIDEO_DEV dependencies

How did I find these? Simply by running git blame on one or more of the
files in the driver at drivers/staging/media/imx

As you can see there are slight variations on the first three but the
general theme is the same, the subject line describes to you that the
driver is found in staging/media and it tells you that the folder of the
driver is 'imx'. Generally, `staging: media: imx` would be preferred
however.
The 4th case shows you an example with a more general subject line and
it is justified in this case as the patch does changes on multiple files
on the whole subsystem (the media subsystem consists of all files found
in drivers/media, drivers/staging/media, Documentation/admin-guide/media
and a few header files).

Now if we take this into account for your subject line. You only change
a single driver, thus you need staging: media: imx:, and you to make
your subject a bit less ambigious you could call the whole thing:

staging: media: imx: Remove duplicate Kconfig dependency

I hope this helps.

Greetings,
Sebastian

>
>---
> drivers/staging/media/imx/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
>index 21fd79515042..772f49b1fe52 100644
>--- a/drivers/staging/media/imx/Kconfig
>+++ b/drivers/staging/media/imx/Kconfig
>@@ -4,7 +4,6 @@ config VIDEO_IMX_MEDIA
> 	depends on ARCH_MXC || COMPILE_TEST
> 	depends on HAS_DMA
> 	depends on VIDEO_DEV
>-	depends on VIDEO_DEV
> 	select MEDIA_CONTROLLER
> 	select V4L2_FWNODE
> 	select V4L2_MEM2MEM_DEV
>-- 
>2.25.1
>
>