[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<BJSPR01MB059504FC203190B95D9D1C549E34A@BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn>
Date: Wed, 27 Mar 2024 02:50:32 +0000
From: ChunHau Tan <chunhau.tan@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>
CC: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>, Vinod Koul
<vkoul@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Leyfoon Tan <leyfoon.tan@...rfivetech.com>, JeeHeng Sia
<jeeheng.sia@...rfivetech.com>, "dmaengine@...r.kernel.org"
<dmaengine@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
support
> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: Wednesday, 27 March, 2024 2:33 AM
> To: ChunHau Tan <chunhau.tan@...rfivetech.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>; Vinod Koul
> <vkoul@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>;
> Leyfoon Tan <leyfoon.tan@...rfivetech.com>; JeeHeng Sia
> <jeeheng.sia@...rfivetech.com>; dmaengine@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> support
>
> On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > controller.
>
> Your commit message should explain what makes this incompatible with existing
> devices. That inforatiion does appear to be in the driver patch, but should also be
> here. Otherwise,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Okay, thank you for the feedback.
>
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@...rfivetech.com>
> > ---
> > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 363cf8bd150d..525f5f3932f5 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -21,6 +21,7 @@ properties:
> > - snps,axi-dma-1.01a
> > - intel,kmb-axi-dma
> > - starfive,jh7110-axi-dma
> > + - starfive,jh8100-axi-dma
> >
> > reg:
> > minItems: 1
> > --
> > 2.25.1
> >
Powered by blists - more mailing lists