linux-kernel - Re: [PATCH] tools/resolve_btfids: fix build with musl libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xr93zfuifhxv.fsf@gthelen-cloudtop.c.googlers.com>
Date: Thu, 28 Mar 2024 09:18:52 -0700
From: Greg Thelen <gthelen@...gle.com>
To: Natanael Copa <ncopa@...inelinux.org>, bpf@...r.kernel.org
Cc: Natanael Copa <ncopa@...inelinux.org>, stable@...r.kernel.org, 
	Viktor Malik <vmalik@...hat.com>, Daniel Xu <dxu@...uu.xyz>, Alexei Starovoitov <ast@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Andrii Nakryiko <andrii@...nel.org>, 
	linux-kernel@...r.kernel.org, Khazhy Kumykov <khazhy@...omium.org>, 
	Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Subject: Re: [PATCH] tools/resolve_btfids: fix build with musl libc

Natanael Copa <ncopa@...inelinux.org> wrote:

> Include the header that defines u32.

> Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with  
> types from btf_ids.h")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647

Tested-by: Greg Thelen <gthelen@...gle.com>

> Cc: stable@...r.kernel.org
> Signed-off-by: Natanael Copa <ncopa@...inelinux.org>
> ---
> This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
> uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.

>   tools/include/linux/btf_ids.h | 2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/tools/include/linux/btf_ids.h b/tools/include/linux/btf_ids.h
> index 72535f00572f..72ea363d434d 100644
> --- a/tools/include/linux/btf_ids.h
> +++ b/tools/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>   #ifndef _LINUX_BTF_IDS_H
>   #define _LINUX_BTF_IDS_H

> +#include <linux/types.h> /* for u32 */
> +
>   struct btf_id_set {
>   	u32 cnt;
>   	u32 ids[];