linux-kernel - Re: [PATCH 1/2] locking/pvqspinlock: Use try_cmpxchg_acquire() in trylock_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38ba7584-3e74-44e3-b1f5-6e42179856a5@redhat.com>
Date: Wed, 27 Mar 2024 21:52:55 -0400
From: Waiman Long <longman@...hat.com>
To: Uros Bizjak <ubizjak@...il.com>, linux-kernel@...r.kernel.org
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will@...nel.org>, Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH 1/2] locking/pvqspinlock: Use try_cmpxchg_acquire() in
 trylock_clear_pending()

On 3/25/24 10:09, Uros Bizjak wrote:
> Use try_cmpxchg_acquire(*ptr, &old, new) instead of
> cmpxchg_relaxed(*ptr, old, new) == old in trylock_clear_pending().
> x86 CMPXCHG instruction returns success in ZF flag, so this change
> saves a compare after cmpxchg.
>
> Also change the return type of the function to bool.
>
> No functional change intended.
>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Waiman Long <longman@...hat.com>
> Cc: Boqun Feng <boqun.feng@...il.com>
> ---
>   kernel/locking/qspinlock_paravirt.h | 31 ++++++++++++-----------------
>   1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h
> index 169950fe1aad..77ba80bd95f9 100644
> --- a/kernel/locking/qspinlock_paravirt.h
> +++ b/kernel/locking/qspinlock_paravirt.h
> @@ -116,11 +116,12 @@ static __always_inline void set_pending(struct qspinlock *lock)
>    * barrier. Therefore, an atomic cmpxchg_acquire() is used to acquire the
>    * lock just to be sure that it will get it.
>    */
> -static __always_inline int trylock_clear_pending(struct qspinlock *lock)
> +static __always_inline bool trylock_clear_pending(struct qspinlock *lock)
>   {
> +	u16 old = _Q_PENDING_VAL;
> +
>   	return !READ_ONCE(lock->locked) &&
> -	       (cmpxchg_acquire(&lock->locked_pending, _Q_PENDING_VAL,
> -				_Q_LOCKED_VAL) == _Q_PENDING_VAL);
> +	       try_cmpxchg_acquire(&lock->locked_pending, &old, _Q_LOCKED_VAL);
>   }
>   #else /* _Q_PENDING_BITS == 8 */
>   static __always_inline void set_pending(struct qspinlock *lock)
> @@ -128,27 +129,21 @@ static __always_inline void set_pending(struct qspinlock *lock)
>   	atomic_or(_Q_PENDING_VAL, &lock->val);
>   }
>   
> -static __always_inline int trylock_clear_pending(struct qspinlock *lock)
> +static __always_inline bool trylock_clear_pending(struct qspinlock *lock)
>   {
> -	int val = atomic_read(&lock->val);
> -
> -	for (;;) {
> -		int old, new;
> -
> -		if (val  & _Q_LOCKED_MASK)
> -			break;
> +	int old, new;
>   
> +	old = atomic_read(&lock->val);
> +	do {
> +		if (old & _Q_LOCKED_MASK)
> +			return false;
>   		/*
>   		 * Try to clear pending bit & set locked bit
>   		 */
> -		old = val;
> -		new = (val & ~_Q_PENDING_MASK) | _Q_LOCKED_VAL;
> -		val = atomic_cmpxchg_acquire(&lock->val, old, new);
> +		new = (old & ~_Q_PENDING_MASK) | _Q_LOCKED_VAL;
> +	} while (!atomic_try_cmpxchg_acquire (&lock->val, &old, new));
>   
> -		if (val == old)
> -			return 1;
> -	}
> -	return 0;
> +	return true;
>   }
>   #endif /* _Q_PENDING_BITS == 8 */
>   
Reviewed-by: Waiman Long <longman@...hat.com>