linux-kernel - Re: [PATCH v4 0/6] iio: temperature: ltc2983: small improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 18:07:21 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Jonathan Cameron <jic23@...nel.org>, Nuno Sa via B4 Relay
	 <devnull+nuno.sa.analog.com@...nel.org>
Cc: nuno.sa@...log.com, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org,  devicetree@...r.kernel.org, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
 Olivier Moysan <olivier.moysan@...s.st.com>, Jyoti Bhayana
 <jbhayana@...gle.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 0/6] iio: temperature: ltc2983: small improvements

On Thu, 2024-03-28 at 16:56 +0000, Jonathan Cameron wrote:
> On Thu, 28 Mar 2024 17:22:00 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@...nel.org> wrote:
> 
> > The v4 introduces an new dev_errp_probe() helper to deal with cases
> > where we want to return error pointers. The refactor in the IIO ltc2983
> > is an heavy user of the pattern and was the main motivation for this.
> > 
> > Also added two new patches so we have three users of the new
> > dev_errp_probe() helper. 
> 
> Probably better to do this as 2 series. The other ltc2983 changes in one series
> and one with a cover letter title that will get noticed by
> those who care about dev_printk helpers.
> 

That makes sense, yes.

- Nuno Sá

> From a quick look the content of the patches is fine.
> 
> Jonathan
> 
> > 
> > ---
> > Changes in v4:
> > - Link to v3:
> > https://lore.kernel.org/r/20240301-ltc2983-misc-improv-v3-0-c09516ac0efc@analog.com
> > - Patch 1
> >  * New patch
> > - Patch 2
> >  * Use dev_errp_probe() instead of local variant
> > - Patch 5
> >  * New patch
> > - Patch 6
> >  * New patch
> > 
> > ---
> > Nuno Sa (6):
> >       printk: add new dev_errp_probe() helper
> >       iio: temperature: ltc2983: convert to dev_err_probe()
> >       dt-bindings: iio: temperature: ltc2983: document power supply
> >       iio: temperature: ltc2983: support vdd regulator
> >       iio: backend: make use dev_errp_probe()
> >       iio: common: scmi_iio: convert to dev_err_probe()
> > 
> >  .../bindings/iio/temperature/adi,ltc2983.yaml      |   4 +
> >  drivers/iio/common/scmi_sensors/scmi_iio.c         |  45 ++--
> >  drivers/iio/industrialio-backend.c                 |   8 +-
> >  drivers/iio/temperature/ltc2983.c                  | 260 ++++++++++-----------
> >  include/linux/dev_printk.h                         |   5 +
> >  5 files changed, 151 insertions(+), 171 deletions(-)
> > ---
> > base-commit: 27eea4778db8268cd6dc80a5b853c599bd3099f1
> > change-id: 20240227-ltc2983-misc-improv-d9c4a3819b1f
> > --
> > 
> > Thanks!
> > - Nuno Sá
> > 
> > 
>