linux-kernel - Re: [PATCH v2 1/3] selftests: x86: test_vsyscall: reorder code to reduce #ifdef blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 12:39:59 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>
Cc: kernel@...labora.com, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 1/3] selftests: x86: test_vsyscall: reorder code to
 reduce #ifdef blocks

On 3/27/24 12:46, Muhammad Usama Anjum wrote:
> There are multiple #ifdef blocks inside functions where they return just
> 0 if #ifdef is false. This makes number of tests counting difficult.
> Move those functions inside one #ifdef block and move all of them
> together. This is preparatory patch for next patch to convert this into
> TAP format. So in this patch, we are just moving functions around
> without any changes.
> 
> With and without this patch, the output of this patch is same.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---

Pulled all three patches in this series. In the future, please
add a cover-letter when you send patch series.

thanks,
-- Shuah