linux-kernel - Re: [PATCH v2 0/6] Improve visibility of writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240328122352.a001a56aed97b01ac5931998@linux-foundation.org>
Date: Thu, 28 Mar 2024 12:23:52 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Kemeng Shi <shikemeng@...weicloud.com>, willy@...radead.org,
 jack@...e.cz, bfoster@...hat.com, tj@...nel.org, dsterba@...e.com,
 mjguzik@...il.com, dhowells@...hat.com, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 0/6] Improve visibility of writeback

On Thu, 28 Mar 2024 15:15:03 -0400 Kent Overstreet <kent.overstreet@...ux.dev> wrote:

> On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote:
> > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi <shikemeng@...weicloud.com> wrote:
> > 
> > > This series tries to improve visilibity of writeback.
> > 
> > Well...  why?  Is anyone usefully using the existing instrumentation? 
> > What is to be gained by expanding it further?  What is the case for
> > adding this code?
> > 
> > I don't recall hearing of anyone using the existing debug
> > instrumentation so perhaps we should remove it!
> 
> Remove debug instrumentation!? Surely you just?

Absolutely not.  Any code in the kernel should have ongoing
justification for remaining there.  If no such justification exists,
out it goes.