| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Mar 2024 04:16:02 +0800
From: kernel test robot <lkp@...el.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
x86@...nel.org
Subject: [tip:sched/core 16/16] kernel/sched/fair.c:9944: warning: Function
parameter or struct member 'sg_overloaded' not described in
'update_sg_lb_stats'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head: f322c65c648eac74cf1f13691a562a0738aa9e35
commit: f322c65c648eac74cf1f13691a562a0738aa9e35 [16/16] sched/balancing: Simplify the sg_status bitmask and use separate sg_overloaded and sg_overutilized flags
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240329/202403290435.TuY2hUx3-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240329/202403290435.TuY2hUx3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403290435.TuY2hUx3-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/sched/fair.c:9944: warning: Function parameter or struct member 'sg_overloaded' not described in 'update_sg_lb_stats'
>> kernel/sched/fair.c:9944: warning: Function parameter or struct member 'sg_overutilized' not described in 'update_sg_lb_stats'
>> kernel/sched/fair.c:9944: warning: Excess function parameter 'sg_status' description in 'update_sg_lb_stats'
vim +9944 kernel/sched/fair.c
c82a69629c53ed kernel/sched/fair.c Vincent Guittot 2022-07-08 9929
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9930 /**
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9931 * update_sg_lb_stats - Update sched_group's statistics for load balancing.
cd96891d48a945 kernel/sched/fair.c Randy Dunlap 2012-06-08 9932 * @env: The load balancing environment.
a315da5e686b02 kernel/sched/fair.c Randy Dunlap 2021-12-17 9933 * @sds: Load-balancing data with statistics of the local group.
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9934 * @group: sched_group whose statistics are to be updated.
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9935 * @sgs: variable to hold the statistics for this group.
630246a06ae2a7 kernel/sched/fair.c Quentin Perret 2018-12-03 9936 * @sg_status: Holds flag indicating the status of the sched_group
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9937 */
bd939f45da24e2 kernel/sched/fair.c Peter Zijlstra 2012-05-02 9938 static inline void update_sg_lb_stats(struct lb_env *env,
c0d14b57fe0c11 kernel/sched/fair.c Ricardo Neri 2021-09-10 9939 struct sd_lb_stats *sds,
630246a06ae2a7 kernel/sched/fair.c Quentin Perret 2018-12-03 9940 struct sched_group *group,
630246a06ae2a7 kernel/sched/fair.c Quentin Perret 2018-12-03 9941 struct sg_lb_stats *sgs,
f322c65c648eac kernel/sched/fair.c Ingo Molnar 2024-03-28 9942 bool *sg_overloaded,
f322c65c648eac kernel/sched/fair.c Ingo Molnar 2024-03-28 9943 bool *sg_overutilized)
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 @9944 {
0b0695f2b34a4a kernel/sched/fair.c Vincent Guittot 2019-10-18 9945 int i, nr_running, local_group;
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9946
b72ff13ce6021b kernel/sched/fair.c Peter Zijlstra 2013-08-28 9947 memset(sgs, 0, sizeof(*sgs));
b72ff13ce6021b kernel/sched/fair.c Peter Zijlstra 2013-08-28 9948
c0d14b57fe0c11 kernel/sched/fair.c Ricardo Neri 2021-09-10 9949 local_group = group == sds->local;
0b0695f2b34a4a kernel/sched/fair.c Vincent Guittot 2019-10-18 9950
ae4df9d6c93510 kernel/sched/fair.c Peter Zijlstra 2017-05-01 9951 for_each_cpu_and(i, sched_group_span(group), env->cpus) {
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9952 struct rq *rq = cpu_rq(i);
c82a69629c53ed kernel/sched/fair.c Vincent Guittot 2022-07-08 9953 unsigned long load = cpu_load(rq);
1e3c88bdeb1260 kernel/sched_fair.c Peter Zijlstra 2009-12-17 9954
c82a69629c53ed kernel/sched/fair.c Vincent Guittot 2022-07-08 9955 sgs->group_load += load;
82762d2af31a60 kernel/sched/fair.c Dietmar Eggemann 2021-11-18 9956 sgs->group_util += cpu_util_cfs(i);
070f5e860ee2bf kernel/sched/fair.c Vincent Guittot 2020-02-24 9957 sgs->group_runnable += cpu_runnable(rq);
a3498347030101 kernel/sched/fair.c Vincent Guittot 2019-10-18 9958 sgs->sum_h_nr_running += rq->cfs.h_nr_running;
4486edd12b5ac8 kernel/sched/fair.c Tim Chen 2014-06-23 9959
a426f99c91d103 kernel/sched/fair.c Waiman Long 2015-11-25 9960 nr_running = rq->nr_running;
5e23e474431529 kernel/sched/fair.c Vincent Guittot 2019-10-18 9961 sgs->sum_nr_running += nr_running;
5e23e474431529 kernel/sched/fair.c Vincent Guittot 2019-10-18 9962
a426f99c91d103 kernel/sched/fair.c Waiman Long 2015-11-25 9963 if (nr_running > 1)
f322c65c648eac kernel/sched/fair.c Ingo Molnar 2024-03-28 9964 *sg_overloaded = 1;
4486edd12b5ac8 kernel/sched/fair.c Tim Chen 2014-06-23 9965
2802bf3cd936fe kernel/sched/fair.c Morten Rasmussen 2018-12-03 9966 if (cpu_overutilized(i))
f322c65c648eac kernel/sched/fair.c Ingo Molnar 2024-03-28 9967 *sg_overutilized = 1;
4486edd12b5ac8 kernel/sched/fair.c Tim Chen 2014-06-23 9968
:::::: The code at line 9944 was first introduced by commit
:::::: 1e3c88bdeb1260edc341e45c9fb8efd182a5c511 sched: Move load balance code into sched_fair.c
:::::: TO: Peter Zijlstra <a.p.zijlstra@...llo.nl>
:::::: CC: Ingo Molnar <mingo@...e.hu>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists