linux-kernel - Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgXUZtEwHEF8Rs3i@google.com>
Date: Thu, 28 Mar 2024 13:34:46 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: WangYuli <wangyuli@...ontech.com>
Cc: rrangel@...omium.org, shaoyang@...ontech.com, helugang@...ontech.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	huangbibo <huangbibo@...ontech.com>
Subject: Re: [PATCH] Input: PS/2 - add support for Lenovo Xiaoxin keyboard

Hi,

On Tue, Mar 26, 2024 at 09:17:18PM +0800, WangYuli wrote:
> Modified keyboard_ids in function ps2_is_keyboard_id
> for Lenovo Xiaoxin keyboard.
> 
> Signed-off-by: yuanjianye <yuanjianye@...ontech.com>
> Signed-off-by: shaoyang <shaoyang@...ontech.com>
> Reviewed-by: huangbibo <huangbibo@...ontech.com>
> Signed-off-by: helugang <helugang@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  drivers/input/serio/libps2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
> index 6d78a1fe00c1..39d46526c56a 100644
> --- a/drivers/input/serio/libps2.c
> +++ b/drivers/input/serio/libps2.c
> @@ -189,6 +189,7 @@ bool ps2_is_keyboard_id(u8 id_byte)
>  		0x5d,	/* Trust keyboard		*/
>  		0x60,	/* NMB SGI keyboard, translated */
>  		0x47,	/* NMB SGI keyboard		*/
> +		0x83,	/* Lenovo Xiaoxin keyboard	*/

Could you please tell me more about the keyboard? What ID does it use?
Majority of keyboards are using 0xab83, does your device forget to send
0xab by chance?

Thanks.

-- 
Dmitry