linux-kernel - Re: [PATCH][next] staging: vt6655: remove redundant assignment to variable byData

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3b033ac-0fe7-4a89-a7f5-ee96d5c806d7@gmail.com>
Date: Thu, 28 Mar 2024 22:44:40 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Colin Ian King <colin.i.king@...il.com>,
 Forest Bond <forest@...ttletooquiet.net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] staging: vt6655: remove redundant assignment to
 variable byData

On 3/28/24 12:15, Colin Ian King wrote:
> Variable byData is being assigned a value that is never read, it is
> being re-assigned later on. The assignment is redundant and can be
> removed.
> 
> Cleans up clang scan build warning:
> drivers/staging/vt6655/srom.c:67:2: warning: Value stored to 'byData'
> is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/staging/vt6655/srom.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 1b89d401a7eb..e80556509c58 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -64,7 +64,6 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
>   	unsigned char byData;
>   	unsigned char byOrg;
>   
> -	byData = 0xFF;
>   	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
>   	/* turn off hardware retry for getting NACK */
>   	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>