linux-kernel - Re: [PATCH net-next] tg3: use sysfs_emit() in tg3_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLikvTWV4Phq6CVm3wj6AC6t_m-M1_thX4pZnu6dnzq7RxQ@mail.gmail.com>
Date: Thu, 28 Mar 2024 14:48:53 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Nikita Kiryushin <kiryushin@...ud.ru>
Cc: Pavan Chebbi <pavan.chebbi@...adcom.com>, Michael Chan <mchan@...adcom.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net-next] tg3: use sysfs_emit() in tg3_show_temp()

On Thu, Mar 28, 2024 at 12:56 PM Nikita Kiryushin <kiryushin@...ud.ru> wrote:
>
> Change sprintf() in sysfs show() handler to sysfs_emit(),
> as recommended by sysfs documentation.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Nikita Kiryushin <kiryushin@...ud.ru>

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Thanks.  We should eventually migrate to use
hwmon_device_register_with_info() so that we don't have to deal with
these sysfs strings.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)