linux-kernel - Re: [PATCH v6 07/14] drm/mediatek: Support alpha blending in display driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 02:52:47 +0000
From: Shawn Sung (宋孝謙) <Shawn.Sung@...iatek.com>
To: CK Hu (胡俊光) <ck.hu@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Bibby Hsieh (謝濟遠) <Bibby.Hsieh@...iatek.com>,
	"jason-ch.chen@...iatek.corp-partner.google.com"
	<jason-ch.chen@...iatek.corp-partner.google.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "airlied@...il.com" <airlied@...il.com>,
	"sean@...rly.run" <sean@...rly.run>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "fshao@...omium.org" <fshao@...omium.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 07/14] drm/mediatek: Support alpha blending in display
 driver

Hi CK,

On Fri, 2024-03-22 at 09:37 +0000, CK Hu (胡俊光) wrote:
> > diff --git a/drivers/gpu/drm/mediatek/mtk_plane.c
> > b/drivers/gpu/drm/mediatek/mtk_plane.c
> > index 1723d4333f371..5bf757a3ef202 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_plane.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_plane.c
> > @@ -346,6 +346,17 @@ int mtk_plane_init(struct drm_device *dev,
> > struct drm_plane *plane,
> >  			DRM_INFO("Create rotation property failed\n");
> >  	}
> >  
> > +	err = drm_plane_create_alpha_property(plane);
> > +	if (err)
> > +		DRM_ERROR("failed to create property: alpha\n");
> > +
> > +	err = drm_plane_create_blend_mode_property(plane,
> > +						   BIT(DRM_MODE_BLEND_P
> > REMULTI) |
> > +						   BIT(DRM_MODE_BLEND_C
> > OVERAGE) |
> > +						   BIT(DRM_MODE_BLEND_P
> > IXEL_NONE));
> 
> After all sub driver support these function, then create blend
> property. So move this patch after all sub driver support these blend
> mode.
> 

Got it. Will rearrange the patches in the next version

Thanks,
Shawn