linux-kernel - Re: [PATCH v16 01/20] security: add ipe lsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde3dc6e-ca77-445e-a4b7-fc21a934999a@infradead.org>
Date: Thu, 28 Mar 2024 15:11:03 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Jarkko Sakkinen <jarkko@...nel.org>, Fan Wu <wufan@...ux.microsoft.com>,
 corbet@....net, zohar@...ux.ibm.com, jmorris@...ei.org, serge@...lyn.com,
 tytso@....edu, ebiggers@...nel.org, axboe@...nel.dk, agk@...hat.com,
 snitzer@...nel.org, eparis@...hat.com, paul@...l-moore.com
Cc: linux-doc@...r.kernel.org, linux-integrity@...r.kernel.org,
 linux-security-module@...r.kernel.org, fsverity@...ts.linux.dev,
 linux-block@...r.kernel.org, dm-devel@...ts.linux.dev,
 audit@...r.kernel.org, linux-kernel@...r.kernel.org,
 Deven Bowers <deven.desai@...ux.microsoft.com>
Subject: Re: [PATCH v16 01/20] security: add ipe lsm



On 3/28/24 13:45, Jarkko Sakkinen wrote:
>> +/**
>> + * ipe_init - Entry point of IPE.
>> + *
>> + * This is called at LSM init, which happens occurs early during kernel
>> + * start up. During this phase, IPE registers its hooks and loads the
>> + * builtin boot policy.
>> + * Return:
>> + * * 0		- OK
>> + * * -ENOMEM	- Out of memory
> Just a suggestion:
> 
> * 0:		OK
> * -ENOMEM:	Out of memory (OOM)
> 
> Rationale being more readable (less convoluted).
> 
> And also sort of symmetrical how parameters are formatted in kdoc.

It needs the " * *" to make a formatted list in the generated output.
Otherwise the use of '- or ':' as a separator doesn't matter AFAIK.

-- 
#Randy