linux-kernel - Re: [PATCH] pinctrl: core: delete incorrect free in pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZw-iG=33gygqy75yzRsv575sqNE=4W-ppKm1QK6fiiMA@mail.gmail.com>
Date: Fri, 29 Mar 2024 00:05:22 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tony Lindgren <tony@...mide.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] pinctrl: core: delete incorrect free in pinctrl_enable()

On Thu, Mar 21, 2024 at 7:38 AM Dan Carpenter <dan.carpenter@...aroorg> wrote:

> The "pctldev" struct is allocated in devm_pinctrl_register_and_init().
> It's a devm_ managed pointer that is freed by devm_pinctrl_dev_release(),
> so freeing it in pinctrl_enable() will lead to a double free.
>
> The devm_pinctrl_dev_release() function frees the pindescs and destroys
> the mutex as well.
>
> Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Great find!

Patch applied for fixes.

Thanks Dan,
Linus Walleij