linux-kernel - Re: [PATCH v3 3/3] vhost: Improve vhost_get_avail_idx() with smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEt5fz9mhZ4YK=Oe+n0kx0YKe4hOnGvVQwh-w4rSfs7uRg@mail.gmail.com>
Date: Thu, 28 Mar 2024 11:54:56 +0800
From: Jason Wang <jasowang@...hat.com>
To: Gavin Shan <gshan@...hat.com>
Cc: virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	mst@...hat.com, will@...nel.org, davem@...emloft.net, stefanha@...hat.com, 
	sgarzare@...hat.com, keirf@...gle.com, yihyu@...hat.com, shan.gavin@...il.com
Subject: Re: [PATCH v3 3/3] vhost: Improve vhost_get_avail_idx() with smp_rmb()

On Thu, Mar 28, 2024 at 8:22 AM Gavin Shan <gshan@...hat.com> wrote:
>
> All the callers of vhost_get_avail_idx() are concerned to the memory
> barrier, imposed by smp_rmb() to ensure the order of the available
> ring entry read and avail_idx read.
>
> Improve vhost_get_avail_idx() so that smp_rmb() is executed when
> the avail_idx is advanced. With it, the callers needn't to worry
> about the memory barrier.
>
> Suggested-by: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Gavin Shan <gshan@...hat.com>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks