linux-kernel - Re: [PATCH v4 0/2] codingstyle: avoid unused parameters for a function-like macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4xfCL3kVDDRNCba2f3+EvOMTGpBW8hkS71ZcvB5UeWZwA@mail.gmail.com>
Date: Thu, 28 Mar 2024 17:22:14 +1300
From: Barry Song <21cnbao@...il.com>
To: akpm@...ux-foundation.org, mac.xxn@...look.com
Cc: apw@...onical.com, broonie@...nel.org, chenhuacai@...ngson.cn, 
	chris@...kel.net, corbet@....net, dwaipayanray1@...il.com, 
	herbert@...dor.apana.org.au, joe@...ches.com, linux-kernel@...r.kernel.org, 
	linux@...ck-us.net, lukas.bulwahn@...il.com, sfr@...b.auug.org.au, 
	v-songbaohua@...o.com, workflows@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 0/2] codingstyle: avoid unused parameters for a
 function-like macro

On Thu, Mar 28, 2024 at 3:21 PM Barry Song <21cnbao@...il.com> wrote:
>
> From: Barry Song <v-songbaohua@...o.com>
>
> -v4:
>  * fix Xining's email address, s/ma.xxn@...look.com/mac.xxn@...look.com/g

Hi Andrew,

Apologies for the oversight. Could you please apply these two patches to replace
the ones in the mm-nonmm-unstable branch? We need to correct Xining's email
address regardless.

>  * fix some false positives of checkpatch.pl
>  * downgrade from ERROR to WARN in checkpatch.pl
>
>  Thanks for Joe's comments!
>
> -v3:
>  https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@gmail.com/
>
> A function-like macro could result in build warnings such as
> "unused variable." This patchset updates the guidance to
> recommend always using a static inline function instead
> and also provides checkpatch support for this new rule.
>
> Barry Song (1):
>   Documentation: coding-style: ask function-like macros to evaluate
>     parameters
>
> Xining Xu (1):
>   scripts: checkpatch: check unused parameters for function-like macro
>
>  Documentation/process/coding-style.rst | 16 ++++++++++++++
>  scripts/checkpatch.pl                  | 30 ++++++++++++++++++++++++++
>  2 files changed, 46 insertions(+)
>
> --
> 2.34.1
>

Thanks
Barry