[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <870730a8-cabc-46ab-9ec9-f8e667842203@amd.com>
Date: Thu, 28 Mar 2024 01:16:43 -0500
From: "Naik, Avadhut" <avadnaik@....com>
To: Sohil Mehta <sohil.mehta@...el.com>, linux-trace-kernel@...r.kernel.org,
linux-edac@...r.kernel.org
Cc: rostedt@...dmis.org, tony.luck@...el.com, bp@...en8.de, x86@...nel.org,
linux-kernel@...r.kernel.org, yazen.ghannam@....com,
Avadhut Naik <avadhut.naik@....com>
Subject: Re: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record
tracepoint
On 3/27/2024 17:31, Sohil Mehta wrote:
> On 3/27/2024 1:54 PM, Avadhut Naik wrote:
>
>> - TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
>> + TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",
>
> Nit: s/MICROCODE REVISION/MICROCODE/g
>
> You could probably get rid of the word REVISION in the interest of
> brevity similar to __print_mce().
>
> pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode
> %x\n",
> m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
> m->microcode);
>
>
Okay. Will remove "REVISION".
> -Sohil
--
Thanks,
Avadhut Naik
Powered by blists - more mailing lists